Change transparent image in Clustering Tutorial so it is readable in dark mode #4258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change transparent svg to a png with white background so that image is viable in dark view mode
|
a white background could be added to the SVG with the same effect right? it would mean faster loading for users and maybe that's preferable. |
|
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
-->Hi – I looked into that but couldn’t see an easy (for me) way of doing that using the markdown. It’s normally done using a CSS style to put a white background onto the containing element. I couldn’t see a way of doing that without changing the main StyleSheet?Somebody who knows the markdown/CSS better than me may have a solution for that? From: HelenaSent: 08 July 2023 08:34To: galaxyproject/training-materialCc: ***@***.***; AuthorSubject: Re: [galaxyproject/training-material] Change transparent image in Clustering Tutorial so it is readable in dark mode (PR #4258) a white background could be added to the SVG with the same effect right? it would mean faster loading for users and maybe that's preferable.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
oh, no, not in the CSS but directly in the SVG, I think it would be easy to maybe just put a large white rectangle behind the drawing or so? I don't think we want to change the CSS currently |
|
Hi @hrukkudyr! I applied @hexylena suggestion but could not push the changes to your PR here, so I made a new PR here: #4636 Thanks a lot for noticing this and creating the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tutorial has a transparent svg image - this is not viable when viewed in dark mode. The svg image has been converted to png with a white background and the file uploaded. Markdown changed to link to new file.